Skip to content

fix: add /mcp-servers prefix & add lint rules#149

Merged
learnerjohn merged 3 commits intohigress-group:mainfrom
JayLi52:main
Jan 9, 2026
Merged

fix: add /mcp-servers prefix & add lint rules#149
learnerjohn merged 3 commits intohigress-group:mainfrom
JayLi52:main

Conversation

@JayLi52
Copy link
Copy Markdown
Contributor

@JayLi52 JayLi52 commented Jan 9, 2026

📝 Description

This PR standardizes the MCP Server path format and improves code quality tooling. The main changes include:

  1. GitHub Actions workflow changes:

    • Disabled ESLint checks in frontend lint workflow by commenting out the configuration
  2. Git Hooks changes:

    • Added .husky/pre-commit file for linting frontend and admin directories before commits
  3. Backend code changes:

    • Modified MCP Server path setting in AdpAIGatewayOperator.java and ApsaraGatewayOperator.java from "/" + data.getName() to "/mcp-servers/" + data.getName()
  4. Frontend configuration changes:

    • Added ESLint and Prettier configurations for both himarket-admin and himarket-frontend projects
    • Added ESLint, Prettier, and lint-staged dependencies to package.json files
    • Added .eslintignore and .prettierrc configuration files
    • Removed old husky pre-commit configuration from frontend
  5. Frontend component changes:

    • Removed special path handling logic for ADP_AI_GATEWAY and APSARA_GATEWAY in ApiProductLinkApi.tsx and McpDetail.tsx

These changes focus on standardizing MCP service path format and improving code quality tooling configuration.

🔗 Related Issues

Fix #issue-number

✅ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧪 Testing

  • Manual testing completed
  • Automated tests added/updated
  • All tests pass locally

@JayLi52 JayLi52 changed the title fix fix: add /mcp-servers prefix Jan 9, 2026
@JayLi52 JayLi52 marked this pull request as draft January 9, 2026 06:22
- 将 MCP Server 配置路径改为 /mcp-servers/ 前缀
- 修复 AdpAIGatewayOperator 和 ApsaraGatewayOperator 中路径设置错误
- 删除前端 ApiProductLinkApi 中对特定源路径的硬编码处理
- 移除 McpDetail 页面中针对路径的特殊拼接逻辑
- 保持路径配置统一,避免前端和后端路径不一致问题
@JayLi52 JayLi52 marked this pull request as ready for review January 9, 2026 06:25
Disabled ESLint execution in both main and create check summary jobs
while preserving the TypeScript type check. The ESLint steps are
commented out rather than removed entirely for potential future re-enablement.
@JayLi52 JayLi52 changed the title fix: add /mcp-servers prefix fix: add /mcp-servers prefix & add lint rules Jan 9, 2026
@learnerjohn learnerjohn self-requested a review January 9, 2026 07:57
@learnerjohn learnerjohn merged commit 8f33a75 into higress-group:main Jan 9, 2026
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants